[llvm-commits] [llvm] r107667 - /llvm/trunk/include/llvm/Instructions.h

[Chris Lattner]

On Jul 6, 2010, at 2:29 PM, Gabor Greif wrote:
>>> +# define public private
>>> +# define protected private
>>>   /// Provide fast operand accessors
>>>   DECLARE_TRANSPARENT_OPERAND_ACCESSORS(Value);
>>> +# undef public
>>> +# undef protected
>> 
>> How about declaring a different macro, named DECLARE_PRIVATE_TRANSPARENT_OPERAND_ACCESSORS or something?
>> 
> 
> Heh, here is my answer from IRC:
> 
> gabor: sabre: re. gross, yes, but I wanted to minimize the patch.
> Actually, my first attempt did just what
> you suggest, but it touched OperandTraits.h, and that appeared too
> much to me. This hack is strictly
> transitional, but if we think it should be in v2.8 (and be removed
> from v2.9) then I am all for rephrasing
> in a less gross way :-)

Alright.

I don't think there is any need to keep this in for 2.8.  We don't guarantee release-to-release API compatibility, I think it can be ripped out in a month or two, before 2.8 is branched.  If it is just a short-term thing, I'm ok keeping it horrible :)

-Chris