[llvm-commits] [patch] Fix PR5094: -fstack-protector fails to link on Linux/x86

Eric Christopher echristo at apple.com
Mon Jul 5 16:08:39 PDT 2010


On Jul 5, 2010, at 4:07 PM, Nelson Elhage wrote:

> Ok, I can split this into arch-specific tests. Would you prefer if I
> make a (nearly-identical) copy of this test for each architecture, or
> just pick one or a handful, and let developers add more if appropriate
> if and when they implement glibc stack cookie support for those targets?
> 
> I guess I should also add a case to the X86 test with
> -mtriple=x86_64-apple-darwin or such, to check that we still use
> __stack_chk_guard in that case.

x86(-64) and ppc would probably be sufficient.  But yes, one for each of the linux and darwin options.

-eric



More information about the llvm-commits mailing list