[llvm-commits] [llvm] r107205 - in /llvm/trunk: bindings/ada/llvm/ docs/ include/llvm-c/ include/llvm/ include/llvm/CodeGen/ include/llvm/MC/ include/llvm/Target/ lib/AsmParser/ lib/Bitcode/Reader/ lib/Bitcode/Writer/ lib/CodeGen/ lib/CodeGen/AsmPrinter/ lib/Linker/ lib/MC/ lib/Target/ lib/Target/CppBackend/ lib/Target/XCore/AsmPrinter/ lib/Transforms/IPO/ lib/VMCore/ tools/llvm-nm/

[Bill Wendling]

On Jun 30, 2010, at 10:49 AM, Bill Wendling wrote:

>>>> Please make this "HasLinkerPrivateWeakLinkage".  There is only one target with this linkage form and it always spells it the same way.  Predicating stuff based on the bool is more clean considering that the *name* is the same as LinkerPrivate the linkage semantics require a new *directive* to be emitted.
>>>> 
>>>> In fact, I don't think you actually need this bit at all since asmprinter handles these symbols like all the other .weak stuff.  Is it needed?
>>>> 
>>> I'll check to see if it's used. If it's not used, then it's relying upon the hack down below, which is bad. However, I much prefer having the prefix string in one place than relying upon it being buried in some deep part of the asm printer.
>> 
>> I don't really understand what you mean.
>> 
> I want to separate it out from the "linker_private" linkage. In particular, I don't want to say that it will always have the same prefix as linker_private. That's the case with Darwin, but I don't see why that has to be the case for every linker that would want to implement it.
> 
Or for every target for that matter. Otherwise, these linkages are restricted to a small subset of usages -- Objective-C metadata on Darwin.

-bw