[llvm-commits] [llvm] r106621 - in /llvm/trunk/lib/Target/X86: X86Instr64bit.td X86InstrInfo.td

[Eric Christopher]

>> 
> 
> If ecx is trashed, it should be listed as a Def, and not as a Use.
> 

OK!

> Also, if all the other registers are preserved, please mention that
> explicitly, as that's a non-obvious difference from regular calls.
> 

Will do.

>>    usesCustomInserter = 1 in
>> def TLSCall_32 : I<0, Pseudo, (outs), (ins i32mem:$sym),
>>                "# Fixme into a call",
> 
> Please add comments noting that this and TLSCall_64 are Darwin-specific.
> 
> Please don't put "Fixme" in the string there. Just put "# TLSCall" or
> whatever, as the other Pseudo instructions do.

Sure.

-eric