[llvm-commits] [llvm] r106119 - /llvm/trunk/lib/CodeGen/MachineSink.cpp

Bill Wendling isanbard at gmail.com
Wed Jun 16 11:01:31 PDT 2010


Author: void
Date: Wed Jun 16 13:01:31 2010
New Revision: 106119

URL: http://llvm.org/viewvc/llvm-project?rev=106119&view=rev
Log:
Improve comment to include that the use of a preg is also verboten in this situation.

Modified:
    llvm/trunk/lib/CodeGen/MachineSink.cpp

Modified: llvm/trunk/lib/CodeGen/MachineSink.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineSink.cpp?rev=106119&r1=106118&r2=106119&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/MachineSink.cpp (original)
+++ llvm/trunk/lib/CodeGen/MachineSink.cpp Wed Jun 16 13:01:31 2010
@@ -282,9 +282,10 @@
   if (MI->getParent() == SuccToSinkTo)
     return false;
 
-  // If the instruction to move defines a dead physical register which is live
-  // when leaving the basic block, don't move it because it could turn into a
-  // "zombie" define of that preg. E.g., EFLAGS. (<rdar://problem/8030636>)
+  // If the instruction to move defines or uses a dead physical register which
+  // is live when leaving the basic block, don't move it because it could turn
+  // into a zombie define or misuse of that preg. E.g., EFLAGS.
+  // (<rdar://problem/8030636>)
   for (unsigned I = 0, E = MI->getNumOperands(); I != E; ++I) {
     const MachineOperand &MO = MI->getOperand(I);
     if (!MO.isReg()) continue;





More information about the llvm-commits mailing list