[llvm-commits] [patch] Remove arm_aapcscc from some tests

Bob Wilson bob.wilson at apple.com
Tue Jun 15 11:44:00 PDT 2010


On Jun 15, 2010, at 11:17 AM, Rafael Espindola wrote:

> Discussing PR7357 over IRC, Nick suggested that the best fix would be
> to change simplify-libcalls to not modify calls with non-default
> calling conventions. This looks reasonable, but to do that we have to
> change the default ARM calling convention to the default (.i.e "") :-)
> 
> The attached patch is a first step in that direction. It just updates
> the tests to use "" instead of arm_aapcscc. I will do the same with
> arm_apcscc and then change llvm-gcc and clang to use "" for the
> default.

This isn't really necessary, is it?  It's still OK to explicitly specify the calling convention, right?  Are you just trying to get better test coverage for using the default ABI?

What's the default ABI for "-mtriple=armv6-elf" or "-march=arm"?  It isn't obvious to me whether those should use APCS or AAPCS, so maybe it is better to explicitly specify the CC in those cases.



More information about the llvm-commits mailing list