[llvm-commits] [patch] Mostly mechanical removal of getPhysicalRegisterRegClass.patch

Rafael Espindola espindola at google.com
Sat Jun 12 21:57:40 PDT 2010


> TLI gets that directly from X86TargetLowering:
>
>    addRegisterClass(MVT::f80, X86::RFP80RegisterClass);
>
> This should not be called after stackification, only during isel. Who calls getRegClassFor() so late?
>
>> This and your comment about wanting the largest available class,
>> suggest that the current function might actually be the correct one in
>> some places. We should be able to at least make it non virtual.
>
>
> getMaximalPhysRegClass(Reg, VT) is a possibility, but I think TLI.getRegClassFor(VT) fits.

Are you suggesting I should change X86TargetLowering to register RST
for f80? This will brake the register allocator, no?

Cheers,
-- 
Rafael Ávila de Espíndola




More information about the llvm-commits mailing list