[llvm-commits] [PATCH] Transforming assertions into OCaml exceptions

[Chris Lattner]

On Jun 11, 2010, at 3:35 PM, Patrick Walton wrote:

> Hi,
> 
> This patch builds on the previous one (llvm-pcwalton-configurable-assertions.diff) and transforms assertions into exceptions in the OCaml bindings.

I'm not sure this is the right way to go.  Assertions should *never* trigger, they are not a checked condition.  Transforming them into an exception is incorrect, because in certain build modes assertions are noops (the checks are not compiled in).

-Chris