[llvm-commits] [llvm] r104891 - in /llvm/trunk: lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp test/CodeGen/ARM/inlineasm.ll

[Chris Lattner]

On May 27, 2010, at 3:08 PM, Evan Cheng wrote:

> Author: evancheng
> Date: Thu May 27 17:08:38 2010
> New Revision: 104891
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=104891&view=rev
> Log:
> llvm can't correctly support 'H', 'Q' and 'R' modifiers. Just mark it an error.

Evan, this should use report_fatal_error, not llvm_unreachable.

-Chris


> 
> Modified:
>    llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp
>    llvm/trunk/test/CodeGen/ARM/inlineasm.ll
> 
> Modified: llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp?rev=104891&r1=104890&r2=104891&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/ARM/AsmPrinter/ARMAsmPrinter.cpp Thu May 27 17:08:38 2010
> @@ -1064,27 +1064,11 @@
>       printOperand(MI, OpNum, O);
>       return false;
>     case 'Q':
> -      // Print the least significant half of a register pair.
> -      if (TM.getTargetData()->isBigEndian())
> -        break;
> -      printOperand(MI, OpNum, O);
> -      return false;
>     case 'R':
> -      // Print the most significant half of a register pair.
> -      if (TM.getTargetData()->isLittleEndian())
> -        break;
> -      printOperand(MI, OpNum, O);
> -      return false;
>     case 'H':
> -      break;
> -    }
> -    // Print the second half of a register pair (for 'Q', 'R' or 'H').
> -    // Verify that this operand has two consecutive registers.
> -    if (!MI->getOperand(OpNum).isReg() ||
> -        OpNum+1 == MI->getNumOperands() ||
> -        !MI->getOperand(OpNum+1).isReg())
> +      llvm_unreachable("llvm does not support 'Q', 'R', and 'H' modifiers!");
>       return true;
> -    ++OpNum;
> +    }
>   }
> 
>   printOperand(MI, OpNum, O);
> 
> Modified: llvm/trunk/test/CodeGen/ARM/inlineasm.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/inlineasm.ll?rev=104891&r1=104890&r2=104891&view=diff
> ==============================================================================
> --- llvm/trunk/test/CodeGen/ARM/inlineasm.ll (original)
> +++ llvm/trunk/test/CodeGen/ARM/inlineasm.ll Thu May 27 17:08:38 2010
> @@ -6,14 +6,6 @@
> }
> 
> define void @test2() {
> -	%tmp1 = call i64 asm "ldmia $1!, {$0, ${0:H}}", "=r,=*r,1"( i32** null, i32* null )		; <i64> [#uses=2]
> -	%tmp2 = lshr i64 %tmp1, 32		; <i64> [#uses=1]
> -	%tmp3 = trunc i64 %tmp2 to i32		; <i32> [#uses=1]
> -	%tmp4 = call i32 asm "pkhbt $0, $1, $2, lsl #16", "=r,r,r"( i32 0, i32 %tmp3 )		; <i32> [#uses=0]
> -	ret void
> -}
> -
> -define void @test3() {
> 	tail call void asm sideeffect "/* number: ${0:c} */", "i"( i32 1 )
> 	ret void
> }
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits