[llvm-commits] [llvm] r103798 - in /llvm/trunk: include/llvm/Analysis/DebugInfo.h lib/Analysis/DebugInfo.cpp lib/CodeGen/AsmPrinter/DwarfDebug.cpp lib/CodeGen/AsmPrinter/DwarfDebug.h

[Devang Patel]

On May 20, 2010, at 11:38 AM, Evan Cheng wrote:

> 
> On May 14, 2010, at 2:19 PM, Devang Patel wrote:
> 
>> 
>> On May 14, 2010, at 2:15 PM, Evan Cheng wrote:
>> 
>>> Hi Devang,
>>> 
>>> Would it be better if the caller of CreateVariable() create the llvm.dbg.lv metadata instead? This solution seems to polluting the interface. 
>> 
>> Technically caller of CreateVariable(), the front end, does not know how variables' debug info is encoded in llvm IR. DebugInfo interface is responsible to encapsulate this detail.
> 
> Ok. Can you at least change "OptimizedBuild" to something that's more API neutral? Perhaps "unknown", "removed"?

I renamed the boolean as AlwaysPreserve and added comment for clarification.
-
Devang