[llvm-commits] [llvm-gcc-4.2] r103997 - /llvm-gcc-4.2/trunk/gcc/cp/mangle.c

[Bob Wilson]

On May 17, 2010, at 4:42 PM, Dale Johannesen wrote:

> 
> On May 17, 2010, at 4:37 PMPDT, Bob Wilson wrote:
> 
>> Author: bwilson
>> Date: Mon May 17 18:37:16 2010
>> New Revision: 103997
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=103997&view=rev
>> Log:
>> Look through typedefs when mangling NEON vector types.  The new arm_mangle_type
>> implementation that looks for the builtin NEON types requires this.
> 
> Is this really safe in general?  I don't see anything limiting the effect to NEON vector types.

It should be safe because all of the other target-specific mangling functions in the llvm-gcc sources already follow the TYPE_MAIN_VARIANT.  But, since you raised the question, I looked again and it seems like it would be more consistent to move that into the arm_mangle_type function.  Then if some other target ever wants to look at the original type, it has the option to do so.