[llvm-commits] [llvm] r103590 - /llvm/trunk/lib/MC/MCSectionCOFF.cpp

[Nathan Jeffords]

Author: njeffords
Date: Wed May 12 02:36:03 2010
New Revision: 103590

URL: http://llvm.org/viewvc/llvm-project?rev=103590&view=rev
Log:
stylistic change to MCSectionCOFF::PrintSwitchToSection COMDAT handling

Made a stylistic changed to the code/comments related to the unsupported COMDAT selection  type IMAGE_COMDAT_SELECT_LARGEST based on from Anton Korobeynikov.

Modified:
    llvm/trunk/lib/MC/MCSectionCOFF.cpp

Modified: llvm/trunk/lib/MC/MCSectionCOFF.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCSectionCOFF.cpp?rev=103590&r1=103589&r2=103590&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCSectionCOFF.cpp (original)
+++ llvm/trunk/lib/MC/MCSectionCOFF.cpp Wed May 12 02:36:03 2010
@@ -50,9 +50,6 @@
   
   if (getCharacteristics() & MCSectionCOFF::IMAGE_SCN_LNK_COMDAT) {
     switch (Selection) {
-      default:
-        assert (0 && "unsupported COFF selection type");
-        break;
       case IMAGE_COMDAT_SELECT_NODUPLICATES:
         OS << "\t.linkonce one_only\n";
         break;
@@ -65,12 +62,15 @@
       case IMAGE_COMDAT_SELECT_EXACT_MATCH:
         OS << "\t.linkonce same_contents\n";
         break;
-      // ".linkonce largest" is not documented as being an option.
-      // It seems odd that a link attribute designed essentially for PE/COFF
-      // wouldn't support all the options (at least as of binutils 2.20)
-    //case IMAGE_COMDAT_SELECT_LARGEST:
+    //NOTE: as of binutils 2.20, there is no way to specifiy select largest
+    //      with the .linkonce directive. For now, we treat it as an invalid
+    //      comdat selection value.
+      case IMAGE_COMDAT_SELECT_LARGEST:
     //  OS << "\t.linkonce largest\n";
     //  break;
+      default:
+        assert (0 && "unsupported COFF selection type");
+        break;
     }
   }
 }