[llvm-commits] [llvm] r103528 - /llvm/trunk/lib/CodeGen/RegAllocFast.cpp

Jakob Stoklund Olesen stoklund at 2pi.dk
Tue May 11 17:11:38 PDT 2010


On May 11, 2010, at 4:53 PM, Daniel Dunbar wrote:

> Author: ddunbar
> Date: Tue May 11 18:53:13 2010
> New Revision: 103528
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=103528&view=rev
> Log:
> Make Clang happy.

Thanks, Daniel. That was clearly bad style, but was it also invalid code? Both Clang and MSVC rejected it.

> 
> Modified:
>    llvm/trunk/lib/CodeGen/RegAllocFast.cpp
> 
> Modified: llvm/trunk/lib/CodeGen/RegAllocFast.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/RegAllocFast.cpp?rev=103528&r1=103527&r2=103528&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/RegAllocFast.cpp (original)
> +++ llvm/trunk/lib/CodeGen/RegAllocFast.cpp Tue May 11 18:53:13 2010
> @@ -584,9 +584,9 @@
>         if (!MO.isReg()) continue;
>         unsigned Reg = MO.getReg();
>         if (!Reg || TargetRegisterInfo::isPhysicalRegister(Reg)) continue;
> -        LiveRegMap::iterator i = LiveVirtRegs.find(Reg);
> -        if (i != LiveVirtRegs.end())
> -          setPhysReg(MO, i->second.PhysReg);
> +        LiveRegMap::iterator it = LiveVirtRegs.find(Reg);
> +        if (it != LiveVirtRegs.end())
> +          setPhysReg(MO, it->second.PhysReg);
>         else
>           MO.setReg(0); // We can't allocate a physreg for a DebugValue, sorry!
>       }
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits





More information about the llvm-commits mailing list