[llvm-commits] Fix for assertion in DAGCombiner

Jan Sjodin jan_sjodin at yahoo.com
Thu Apr 29 12:26:04 PDT 2010


> Thinking about this a little more, I think this patch is 

> fine, for its part. However, the current one doesn't apply cleanly;
> at a glance, it looks like the whitespace isn't quite correct.
> Could you re-send it, possibly as an attachment?

I guess the argument could be made that this kind of lowering to
get legal code should not be done in the DAGCombiner. Relying
on a pure optimization to get correct code is not clean imo. However,
it may already impossible to exclude the DAGCombiner to get correct
code for all backends. In any case I updated and regenerated the patch
Let me know if you have issues applying this. 

Thanks,
Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0018_vector_setcc_combine.patch
Type: application/octet-stream
Size: 2263 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100429/cf86094e/attachment.obj>


More information about the llvm-commits mailing list