[llvm-commits] [llvm] r102519 - in /llvm/trunk: lib/VMCore/Metadata.cpp test/Transforms/GlobalOpt/metadata.ll

[Duncan Sands]

Hi Chris,

> fix PR6112 - When globalopt (or any other pass) does RAUW(@G, %G),
> metadata references in non-function-local MDNodes should drop to
> null.

thanks for fixing this.  However there is the theoretical possibility
that the metadata M using @G is function local, but for a different
function to the function containing %G.  That will result in inconsistent
functions for M and %G, which is not allowed AFAIK.  Probably the thing
to do is to return the containing function in isFunctionLocalValue, or
NULL if there is none, and compare with that of the metadata.

Ciao,

Duncan.