[llvm-commits] [llvm] r102410 - /llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

[Dale Johannesen]

Author: johannes
Date: Mon Apr 26 21:10:05 2010
New Revision: 102410

URL: http://llvm.org/viewvc/llvm-project?rev=102410&view=rev
Log:
Revert a small part of 102372; this fixes at least one
of the dbg testsuite regressions.  I don't think this is
really the right fix; this change exposed an existing problem
upstream somewhere.


Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp?rev=102410&r1=102409&r2=102410&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp Mon Apr 26 21:10:05 2010
@@ -3834,10 +3834,15 @@
         return 0;
       DAG.AddDbgValue(SDV, N.getNode(), isParameter);
     } else {
+      // Generating Undefs here seems to be actively harmful because it
+      // affects the line numbers.
+      return 0;
+#if 0
       // This isn't useful, but it shows what we're missing.
       SDV = DAG.getDbgValue(Variable, UndefValue::get(Address->getType()),
                             0, dl, SDNodeOrder);
       DAG.AddDbgValue(SDV, 0, isParameter);
+#endif
     }
     return 0;
   }