[llvm-commits] [llvm] r101855 - in /llvm/trunk: lib/CodeGen/SelectionDAG/DAGCombiner.cpp test/CodeGen/X86/2010-04-19-DAGCombineCrash.ll

[Chris Lattner]

On Apr 19, 2010, at 6:25 PM, Bill Wendling wrote:

> Author: void
> Date: Mon Apr 19 20:25:01 2010
> New Revision: 101855
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=101855&view=rev
> Log:
> The visitXOR method can return the same SDNode. If so, we don't want to delete
> it as it's not dead.

Please hand reduce the testcase and add it to the end of test/CodeGen/X86/crash.ll, thanks.

-Chris

> 
> Added:
>    llvm/trunk/test/CodeGen/X86/2010-04-19-DAGCombineCrash.ll
> Modified:
>    llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
> 
> Modified: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=101855&r1=101854&r2=101855&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (original)
> +++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp Mon Apr 19 20:25:01 2010
> @@ -4911,7 +4911,7 @@
>     if (Op0.getOpcode() == Op1.getOpcode()) {
>       // Avoid missing important xor optimizations.
>       SDValue Tmp = visitXOR(TheXor);
> -      if (Tmp.getNode()) {
> +      if (Tmp.getNode() && Tmp.getNode() != TheXor) {
>         DEBUG(dbgs() << "\nReplacing.8 ";
>               TheXor->dump(&DAG);
>               dbgs() << "\nWith: ";
> 
> Added: llvm/trunk/test/CodeGen/X86/2010-04-19-DAGCombineCrash.ll
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/2010-04-19-DAGCombineCrash.ll?rev=101855&view=auto
> ==============================================================================
> --- llvm/trunk/test/CodeGen/X86/2010-04-19-DAGCombineCrash.ll (added)
> +++ llvm/trunk/test/CodeGen/X86/2010-04-19-DAGCombineCrash.ll Mon Apr 19 20:25:01 2010
> @@ -0,0 +1,58 @@
> +; RUN: llc < %s -mtriple=i386-apple-darwin
> +; rdar://7869290
> +
> +%struct.anon = type { float }
> +
> +define void @func() nounwind ssp {
> +entry:
> +  br label %bb66
> +
> +bb:                                               ; preds = %bb66
> +  br i1 undef, label %bb65, label %bb2
> +
> +bb2:                                              ; preds = %bb
> +  br i1 undef, label %bb65, label %bb3
> +
> +bb3:                                              ; preds = %bb2
> +  br i1 undef, label %bb65, label %bb4
> +
> +bb4:                                              ; preds = %bb3
> +  br i1 undef, label %bb65, label %bb5
> +
> +bb5:                                              ; preds = %bb4
> +  br i1 undef, label %bb65, label %bb6
> +
> +bb6:                                              ; preds = %bb5
> +  br i1 undef, label %bb65, label %bb11
> +
> +bb11:                                             ; preds = %bb6
> +  br i1 undef, label %bb65, label %bb12
> +
> +bb12:                                             ; preds = %bb11
> +  br i1 undef, label %bb65, label %bb13
> +
> +bb13:                                             ; preds = %bb12
> +  br i1 undef, label %bb65, label %bb14
> +
> +bb14:                                             ; preds = %bb13
> +  %0 = trunc i16 undef to i1                      ; <i1> [#uses=1]
> +  %1 = load i8* undef, align 8                    ; <i8> [#uses=1]
> +  %2 = shl i8 %1, 4                               ; <i8> [#uses=1]
> +  %3 = lshr i8 %2, 7                              ; <i8> [#uses=1]
> +  %4 = trunc i8 %3 to i1                          ; <i1> [#uses=1]
> +  %5 = icmp ne i1 %0, %4                          ; <i1> [#uses=1]
> +  br i1 %5, label %bb65, label %bb15
> +
> +bb15:                                             ; preds = %bb14
> +  %6 = load %struct.anon** undef, align 8         ; <%struct.anon*> [#uses=0]
> +  br label %bb65
> +
> +bb65:                                             ; preds = %bb15, %bb14, %bb13, %bb12, %bb11, %bb6, %bb5, %bb4, %bb3, %bb2, %bb
> +  br label %bb66
> +
> +bb66:                                             ; preds = %bb65, %entry
> +  br i1 undef, label %bb, label %bb67
> +
> +bb67:                                             ; preds = %bb66
> +  ret void
> +}
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits