[llvm-commits] [llvm] r100896 - in /llvm/trunk: Makefile.config.in lib/Transforms/Makefile runtime/Makefile

[Anton Korobeynikov]

Hi, Chris

> suck the propagating "has dynamic libs" check into a single makefile
> variable TARGET_HAS_DYNAMIC_LIBS
This seems to break mingw32 buildbot. See
http://google1.osuosl.org:8011/builders/llvm-gcc-x86_64-darwin10-cross-mingw32/builds/2636

In fact, this change is invalid:
>-# No support for plugins on windows targets
>-ifeq ($(HOST_OS), $(filter $(HOST_OS), Cygwin MingW Minix))
>+# Some targets don't support plugins
>+ifdef $(TARGET_HAS_DYNAMIC_LIBS)
>  PARALLEL_DIRS := $(filter-out Hello, $(PARALLEL_DIRS))
> endif
Here you changed HOST_OS into TARGET_OS, which is incorrect.

-- 
With best regards, Anton Korobeynikov
Faculty of Mathematics and Mechanics, Saint Petersburg State University