[llvm-commits] [PATCH] Implement a better patch for LLVM bug PR56

[Chris Lattner]

On Apr 8, 2010, at 10:42 AM, Sylvere Teissier wrote:

> Hi,
> I've implemented the support of empty vaarg functions in CBE and removed
> the current workaround: (bellow is the comment with the old workaround)
> 
> // Work around LLVM bug PR56: the CWriter cannot emit varargs functions
> which
> // have zero fixed arguments.
> //
> // Note that we apply this hack for a vararg fuction that does not have any
> // arguments anymore, but did have them before (so don't bother fixing
> // functions that were already broken wrt CWriter).

Looks good to me, committed here:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20100405/099584.html

This makes the CBE and native code generators not agree on the ABI of these functions, but the CBE already has lots of similar problems.

Thanks!

-Chris