[llvm-commits] [llvm] r100530 - in /llvm/trunk: lib/CodeGen/AsmPrinter/DwarfDebug.cpp lib/CodeGen/AsmPrinter/DwarfDebug.h test/FrontendC++/2010-02-17-DbgArtificialArg.cpp

Stuart Hastings stuart at apple.com
Tue Apr 6 11:33:46 PDT 2010


On Apr 6, 2010, at 11:25 AM, Devang Patel wrote:

> 
> On Apr 6, 2010, at 10:19 AM, Stuart Hastings wrote:
> 
>> 
>> +/// isFunctionContext - True if given Context is nested within a function. 
>> +bool DwarfDebug::isFunctionContext(DIE *context) {
>> +  if (context == (DIE *)0)
>> +    return false;
>> +  if (context->getTag() == dwarf::DW_TAG_subprogram)
>> +    return true;
>> +  else
>> +    return isFunctionContext(context->getParent());
>> +}
>> +
> 
> I do not see any use of this function.

Dunno how I screwed that up.  It was created to be invoked from DwarfDebug.cpp:DwarfDebug::updateSubprogramScopeDIE(); there's a check there that gets fooled by a nested function/class/function.

I'll fix this after the BuildBots have ruled on my previous checkin.

Thanks for pointing this out,

stuart



More information about the llvm-commits mailing list