[llvm-commits] [llvm] r100346 - in /llvm/trunk: lib/CodeGen/AsmPrinter/AsmPrinter.cpp test/CodeGen/X86/personality.ll

Chris Lattner sabre at nondot.org
Sun Apr 4 12:28:59 PDT 2010


Author: lattner
Date: Sun Apr  4 14:28:59 2010
New Revision: 100346

URL: http://llvm.org/viewvc/llvm-project?rev=100346&view=rev
Log:
resolve a fixme.

Modified:
    llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
    llvm/trunk/test/CodeGen/X86/personality.ll

Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=100346&r1=100345&r2=100346&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (original)
+++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp Sun Apr  4 14:28:59 2010
@@ -1350,12 +1350,7 @@
 /// GetTempSymbol - Return the MCSymbol corresponding to the assembler
 /// temporary label with the specified stem and unique ID.
 MCSymbol *AsmPrinter::GetTempSymbol(StringRef Name, unsigned ID) const {
-  // FIXME: REMOVE this.  However, there is stuff in EH that passes counters in
-  // here that can be zero.
-  
-  //assert(ID && "Should use GetTempSymbol if no ID");
-  if (ID == 0) return GetTempSymbol(Name);
-  return OutContext.GetOrCreateSymbol(Twine(MAI->getPrivateGlobalPrefix())+
+  return OutContext.GetOrCreateSymbol(Twine(MAI->getPrivateGlobalPrefix()) +
                                       Name + Twine(ID));
 }
 

Modified: llvm/trunk/test/CodeGen/X86/personality.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/personality.ll?rev=100346&r1=100345&r2=100346&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/personality.ll (original)
+++ llvm/trunk/test/CodeGen/X86/personality.ll Sun Apr  4 14:28:59 2010
@@ -38,10 +38,10 @@
 
 declare void @__cxa_end_catch()
 
-; X64: Leh_frame_common_begin:
+; X64: Leh_frame_common_begin0:
 ; X64: .long	___gxx_personality_v0 at GOTPCREL+4
 
-; X32: Leh_frame_common_begin:
+; X32: Leh_frame_common_begin0:
 ; X32: .long	L___gxx_personality_v0$non_lazy_ptr-
 ; ....
 





More information about the llvm-commits mailing list