[llvm-commits] [llvm] r100328 - /llvm/trunk/lib/ExecutionEngine/JIT/JITEmitter.cpp

[Chris Lattner]

On Apr 4, 2010, at 3:31 AM, Nicolas Geoffray wrote:

> Author: geoffray
> Date: Sun Apr  4 05:31:49 2010
> New Revision: 100328
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=100328&view=rev
> Log:
> CurFn is only used for relocations. Use EmissionDetails.MF->getFunction() instead.

Hi Nicolas,

If you're interested in this code, it would be really nice to propagate use of DebugLoc through it instead of using DILocation.  This would make it a lot more efficient,

-Chris

> 
> 
> Modified:
>    llvm/trunk/lib/ExecutionEngine/JIT/JITEmitter.cpp
> 
> Modified: llvm/trunk/lib/ExecutionEngine/JIT/JITEmitter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/JIT/JITEmitter.cpp?rev=100328&r1=100327&r2=100328&view=diff
> ==============================================================================
> --- llvm/trunk/lib/ExecutionEngine/JIT/JITEmitter.cpp (original)
> +++ llvm/trunk/lib/ExecutionEngine/JIT/JITEmitter.cpp Sun Apr  4 05:31:49 2010
> @@ -825,7 +825,8 @@
>   if (!BeforePrintingInsn) return;
> 
>   // FIXME: This is horribly inefficient.
> -  DILocation CurDLT(DL.getAsMDNode(CurFn->getContext()));
> +  DILocation CurDLT(DL.getAsMDNode(
> +    EmissionDetails.MF->getFunction()->getContext()));
> 
>   if (CurDLT.getScope().getNode() != 0 && PrevDLT.getNode() !=CurDLT.getNode()){
>     JITEvent_EmittedFunctionDetails::LineStart NextLine;
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits