[llvm-commits] [llvm] r100312 - /llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp

Chris Lattner sabre at nondot.org
Sat Apr 3 22:21:31 PDT 2010


Author: lattner
Date: Sun Apr  4 00:21:31 2010
New Revision: 100312

URL: http://llvm.org/viewvc/llvm-project?rev=100312&view=rev
Log:
use predicates in DBG_VALUE printing code to simplify it.

Modified:
    llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp

Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp?rev=100312&r1=100311&r2=100312&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp (original)
+++ llvm/trunk/lib/Target/X86/AsmPrinter/X86MCInstLower.cpp Sun Apr  4 00:21:31 2010
@@ -344,16 +344,17 @@
     O << " <- ";
     if (NOps==3) {
       // Register or immediate value. Register 0 means undef.
-      assert(MI->getOperand(0).getType()==MachineOperand::MO_Register ||
-             MI->getOperand(0).getType()==MachineOperand::MO_Immediate ||
-             MI->getOperand(0).getType()==MachineOperand::MO_FPImmediate);
-      if (MI->getOperand(0).getType()==MachineOperand::MO_Register &&
-          MI->getOperand(0).getReg()==0) {
+      assert(MI->getOperand(0).isReg() ||
+             MI->getOperand(0).isImm() ||
+             MI->getOperand(0).isFPImm());
+      if (MI->getOperand(0).isReg() && MI->getOperand(0).getReg() == 0) {
         // Suppress offset in this case, it is not meaningful.
         O << "undef";
         OutStreamer.AddBlankLine();
         return;
-      } else if (MI->getOperand(0).getType()==MachineOperand::MO_FPImmediate) {
+      }
+      
+      if (MI->getOperand(0).isFPImm()) {
         // This is more naturally done in printOperand, but since the only use
         // of such an operand is in this comment and that is temporary (and it's
         // ugly), we prefer to keep this localized.
@@ -373,16 +374,14 @@
       } else
         printOperand(MI, 0, O);
     } else {
-      if (MI->getOperand(0).getType()==MachineOperand::MO_Register &&
-          MI->getOperand(0).getReg()==0) {
+      if (MI->getOperand(0).isReg() && MI->getOperand(0).getReg() == 0) {
         // Suppress offset in this case, it is not meaningful.
         O << "undef";
         OutStreamer.AddBlankLine();
         return;
       }
       // Frame address.  Currently handles register +- offset only.
-      assert(MI->getOperand(0).getType()==MachineOperand::MO_Register);
-      assert(MI->getOperand(3).getType()==MachineOperand::MO_Immediate);
+      assert(MI->getOperand(0).isReg() && MI->getOperand(3).isImm());
       O << '['; printOperand(MI, 0, O); O << '+'; printOperand(MI, 3, O);
       O << ']';
     }





More information about the llvm-commits mailing list