[llvm-commits] [llvm] r100265 - in /llvm/trunk/lib/Target/ARM/Disassembler: ARMDisassemblerCore.cpp ARMDisassemblerCore.h

[Bob Wilson]

Johnny,

Your patches have broken a number of the buildbots:

smooshlab:llvm-gcc-powerpc-darwin9
google:llvm-ppc-linux
	The arm-tests.txt, neon-tests.txt and thumb-tests.txt tests are failing.

smooshlab:llvm-gcc-x86_64-darwin10-miniswb
smooshlab:llvm-gcc-x86_64-darwin10-selfhost
google:llvm-gcc-x86_64-darwin10-selfhost
	There is a segfault building lib/Target/ARM/Release/ARMGenDecoderTables.inc.tmp.

Please fix these ASAP or revert your changes.  Leaving buildbots broken means that we lose track of any new regressions during that time, so we really want to avoid that.

Thanks.

On Apr 2, 2010, at 10:52 PM, Johnny Chen wrote:

> That's it!  Thanks for the pointer.
> I can sleep better tonight. :-)
> 
> There are typos in include/llvm/Config/Disassemblers.def.in:
> 
> // This file enumerates all of the assembly-language parsers
> // supported by this build of LLVM. Clients of this file should define
> // the LLVM_ASM_PARSER macro to be a function-like macro with a
> // single parameter (the name of the target whose assembly can be
> // generated); including this file will then enumerate all of the
> // targets with assembly parsers.
> 
> On Apr 2, 2010, at 10:18 PM, Chris Lattner wrote:
> 
>> 
>> On Apr 2, 2010, at 10:09 PM, Johnny Chen wrote:
>> 
>>> I have a git directory where I use GitX to browse the checkins:
>>> 
>>> [21:54:11] johnny:/Volumes/data/llvm/git/trunk (local-trunk) $ nm Debug/bin/llvm-mc | grep LLVMInitializeARM
>>> 000000010012af58 t _LLVMInitializeARMAsmParser
>>> 000000010012f530 t _LLVMInitializeARMAsmPrinter
>>> 00000001001b202d t _LLVMInitializeARMTarget
>>> 00000001001c029d t _LLVMInitializeARMTargetInfo
>>> 0000000100009849 t __GLOBAL__I_LLVMInitializeARMAsmPrinter
>>> [21:58:34] johnny:/Volumes/data/llvm/git/trunk (local-trunk) $ 
>>> 
>>> And I also have a svn directory for my development:
>>> 
>>> [21:51:38] johnny:/Volumes/data/llvm/svn/commit $ nm ./Release/bin/llvm-mc | grep LLVMInitializeARM
>>> 000000010016d8b0 t _LLVMInitializeARMAsmParser
>>> 0000000100170330 t _LLVMInitializeARMAsmPrinter
>>> 0000000100158df0 t _LLVMInitializeARMDisassembler
>>> 0000000100203250 t _LLVMInitializeARMTarget
>>> 0000000100214180 t _LLVMInitializeARMTargetInfo
>>> 0000000100012fe0 t __GLOBAL__I_LLVMInitializeARMAsmPrinter
>>> [21:58:25] johnny:/Volumes/data/llvm/svn/commit $ 
>>> 
>>> As you can see, the git dir's llvm-mc is missing the arm disassembler stuff.
>>> The relevant definition LLVMInitializeARMDisassembler is in the git dir's ./Debug/lib/libLLVMARMDisassembler.a;
>>> however, I have a hard time figuring out why it is not in the git dir's llvm-mc executable.  Any pointer?
>> 
>> I don't know anything about git.
>> 
>> Did you reconfigure llvm?  Make sure that ARM is listed in include/llvm/Config/Disassemblers.def
>> 
>> -Chris
>> 
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits