[llvm-commits] [llvm] r99895 - /llvm/trunk/lib/CodeGen/LiveInterval.cpp

[Daniel Dunbar]

Hey Lang,

Not sure if you are still poking at this code, but each of these edits
is in four copies of the same code -- shouldn't it be factored out?

 - Daniel

On Tue, Mar 30, 2010 at 10:57 AM, Daniel Dunbar <daniel at zuster.org> wrote:
> Author: ddunbar
> Date: Tue Mar 30 12:57:42 2010
> New Revision: 99895
>
> URL: http://llvm.org/viewvc/llvm-project?rev=99895&view=rev
> Log:
> Fix -Asserts warning.
>
> Modified:
>    llvm/trunk/lib/CodeGen/LiveInterval.cpp
>
> Modified: llvm/trunk/lib/CodeGen/LiveInterval.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/LiveInterval.cpp?rev=99895&r1=99894&r2=99895&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/LiveInterval.cpp (original)
> +++ llvm/trunk/lib/CodeGen/LiveInterval.cpp Tue Mar 30 12:57:42 2010
> @@ -303,7 +303,6 @@
>           // otherwise mark it as ~1U so it can be nuked later.
>           if (ValNo->id == getNumValNums()-1) {
>             do {
> -              VNInfo *VNI = valnos.back();
>               valnos.pop_back();
>             } while (!valnos.empty() && valnos.back()->isUnused());
>           } else {
> @@ -350,7 +349,6 @@
>   // otherwise mark it as ~1U so it can be nuked later.
>   if (ValNo->id == getNumValNums()-1) {
>     do {
> -      VNInfo *VNI = valnos.back();
>       valnos.pop_back();
>     } while (!valnos.empty() && valnos.back()->isUnused());
>   } else {
> @@ -577,7 +575,6 @@
>         // mark it as ~1U so it can be nuked later.
>         if (V1->id == getNumValNums()-1) {
>           do {
> -            VNInfo *VNI = valnos.back();
>             valnos.pop_back();
>           } while (!valnos.empty() && valnos.back()->isUnused());
>         } else {
> @@ -745,7 +742,6 @@
>   // ~1U so it can be nuked later.
>   if (V1->id == getNumValNums()-1) {
>     do {
> -      VNInfo *VNI = valnos.back();
>       valnos.pop_back();
>     } while (valnos.back()->isUnused());
>   } else {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>