[llvm-commits] [llvm] r99490 - /llvm/trunk/lib/VMCore/Metadata.cpp

[Chris Lattner]

On Mar 24, 2010, at 11:15 PM, Devang Patel wrote:

> 
> On Mar 24, 2010, at 11:06 PM, Chris Lattner wrote:
> 
>> 
>> On Mar 24, 2010, at 11:04 PM, Devang Patel wrote:
>> 
>>> Author: dpatel
>>> Date: Thu Mar 25 01:04:47 2010
>>> New Revision: 99490
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=99490&view=rev
>>> Log:
>>> Include isFunctionLocal while calculating folding node set profile for a MDNode.
>> 
>> Can this code call MDNode::Profile instead of duplicating it?
> 
> MDNode::getMDNode() calculates profile based on incoming value list before creating MDNode.

Please define the code in the class as a static method.  For example, check out how the AttributeListImpl::Profile methods work.  This keeps the code close together so they don't start to drift.  Thanks!

-Chris