[llvm-commits] [test-suite] r99329 - /test-suite/trunk/TEST.m2regllcdbg.Makefile

Chris Lattner clattner at apple.com
Tue Mar 23 16:02:33 PDT 2010


On Mar 23, 2010, at 3:26 PM, Dale Johannesen wrote:

> 
> On Mar 23, 2010, at 2:36 PMPDT, Bill Wendling wrote:
> 
>> Remove "crit_edge*" comments. These could change, but they don't effect code
>> generation.
> 
> The comments don't affect codegen, but the reason they change is that additional tmp symbols (a duplicate of some value that is already available elsewhere) are generated in one case.  It is true that some later pass clears up these dupes in all the examples I've looked at, so the only difference is the comments, but I'm unpersuaded this is always true, and I don't think this patch is a good idea.

Labels being different is different than comments being different.  I'd consider label differences, even if they are "L" labels to be a serious problem.

-Chris



More information about the llvm-commits mailing list