[llvm-commits] [test-suite] r99329 - /test-suite/trunk/TEST.m2regllcdbg.Makefile

[Dale Johannesen]

On Mar 23, 2010, at 2:36 PMPDT, Bill Wendling wrote:

> Remove "crit_edge*" comments. These could change, but they don't effect code
> generation.

The comments don't affect codegen, but the reason they change is that additional tmp symbols (a duplicate of some value that is already available elsewhere) are generated in one case.  It is true that some later pass clears up these dupes in all the examples I've looked at, so the only difference is the comments, but I'm unpersuaded this is always true, and I don't think this patch is a good idea.

The debugging patch here will dump out tmp symbols as they are created; you'll see what I mean:
-------------- next part --------------
A non-text attachment was scrubbed...
Name: diffs.vstb
Type: application/octet-stream
Size: 1121 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100323/e5ba2574/attachment.obj>
-------------- next part --------------