[llvm-commits] [llvm] r98666 - /llvm/trunk/test/Feature/unions.ll

[Chris Lattner]

Sorry, I missed your revert.  I tested my xfail locally before committing it.

Unions are half baked anyway, I wasn't worried about breaking them.

-Chris

On Mar 16, 2010, at 1:56 PM, Daniel Dunbar wrote:

> This was the wrong solution, (a) because I already reverted the patch,
> and (b) because it doesn't make sense to XFAIL a test which only
> started failing by a commit to exactly-that-which-it-is-testing.
> Reverting the initial patch is more reasonable, which would also have
> nicely given you a friendly svn conflict. :)
> 
> - Daniel
> 
> On Tue, Mar 16, 2010 at 1:08 PM, Chris Lattner <sabre at nondot.org> wrote:
>> Author: lattner
>> Date: Tue Mar 16 15:08:07 2010
>> New Revision: 98666
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=98666&view=rev
>> Log:
>> temporarily xfail
>> 
>> Modified:
>>    llvm/trunk/test/Feature/unions.ll
>> 
>> Modified: llvm/trunk/test/Feature/unions.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Feature/unions.ll?rev=98666&r1=98665&r2=98666&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/Feature/unions.ll (original)
>> +++ llvm/trunk/test/Feature/unions.ll Tue Mar 16 15:08:07 2010
>> @@ -1,7 +1,7 @@
>>  ; RUN: llvm-as < %s | llvm-dis > %t1.ll
>>  ; RUN: llvm-as %t1.ll -o - | llvm-dis > %t2.ll
>>  ; RUN: diff %t1.ll %t2.ll
>> -
>> +; XFAIL: *
>>  %union.anon = type union { i8, i32, float }
>> 
>>  @union1 = constant union { i32, i8 } { i32 4 }
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits