[llvm-commits] [llvm] r98637 - in /llvm/trunk: ./ lib/Target/ARM/ lib/Target/ARM/AsmPrinter/ lib/Target/ARM/Disassembler/ test/CodeGen/ARM/ test/CodeGen/Thumb2/ utils/TableGen/

[Johnny Chen]

Thanks!

On Mar 16, 2010, at 10:25 AM, Benjamin Kramer wrote:

> 
> On 16.03.2010, at 18:01, Bob Wilson wrote:
> 
>> I've reverted this since it broke the buildbots.  I'd like a chance to review this before you re-commit with fixes.
> 
> Valgrind log
> 
> ==61801== Conditional jump or move depends on uninitialised value(s)
> ==61801==    at 0x1000E4A2B: llvm::RISCDisassemblerEmitter::RISCDEBackend::populateInstructions() (RISCDisassemblerEmitter.cpp:1635)
> ==61801==    by 0x1000E4C88: llvm::RISCDisassemblerEmitter::RISCDEBackend::RISCDEBackend(llvm::RISCDisassemblerEmitter&) (RISCDisassemblerEmitter.cpp:1382)
> ==61801==    by 0x1000DA4BB: llvm::RISCDisassemblerEmitter::initBackend() (RISCDisassemblerEmitter.cpp:1731)
> ==61801==    by 0x10009FB7C: llvm::RISCDisassemblerEmitter::RISCDisassemblerEmitter(llvm::RecordKeeper&) (RISCDisassemblerEmitter.h:27)
> ==61801==    by 0x10009F7E8: llvm::DisassemblerEmitter::run(llvm::raw_ostream&) (DisassemblerEmitter.cpp:131)
> ==61801==    by 0x10012405E: main (TableGen.cpp:250)
> ==61801==  Uninitialised value was created by a heap allocation
> ==61801==    at 0x1005076DE: operator new(unsigned long) (vg_replace_malloc.c:261)
> ==61801==    by 0x1000DA4AA: llvm::RISCDisassemblerEmitter::initBackend() (RISCDisassemblerEmitter.cpp:1731)
> ==61801==    by 0x10009FB7C: llvm::RISCDisassemblerEmitter::RISCDisassemblerEmitter(llvm::RecordKeeper&) (RISCDisassemblerEmitter.h:27)
> ==61801==    by 0x10009F7E8: llvm::DisassemblerEmitter::run(llvm::raw_ostream&) (DisassemblerEmitter.cpp:131)
> ==61801==    by 0x10012405E: main (TableGen.cpp:250)
> 
> i.e. populateInstructions was called before TargetName was initialized.