[llvm-commits] [llvm] r98367 - /llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp

Chris Lattner sabre at nondot.org
Fri Mar 12 11:04:15 PST 2010


Author: lattner
Date: Fri Mar 12 13:04:14 2010
New Revision: 98367

URL: http://llvm.org/viewvc/llvm-project?rev=98367&view=rev
Log:
use Mang->getSymbol instead of duplicating the logic, reduce indentation.

Modified:
    llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp

Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp?rev=98367&r1=98366&r2=98367&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp (original)
+++ llvm/trunk/lib/Target/X86/AsmPrinter/X86AsmPrinter.cpp Fri Mar 12 13:04:14 2010
@@ -54,25 +54,19 @@
 }
 
 MCSymbol *X86AsmPrinter::GetGlobalValueSymbol(const GlobalValue *GV) const {
-  SmallString<60> NameStr;
-  Mang->getNameWithPrefix(NameStr, GV, false);
-  MCSymbol *Symb;
-  if (GV->hasPrivateLinkage())
-    Symb = OutContext.GetOrCreateTemporarySymbol(NameStr.str());
-  else
-    Symb = OutContext.GetOrCreateSymbol(NameStr.str());
-
-  if (Subtarget->isTargetCygMing()) {
-    X86COFFMachineModuleInfo &COFFMMI =
-      MMI->getObjFileInfo<X86COFFMachineModuleInfo>();
-    COFFMMI.DecorateCygMingName(Symb, OutContext, GV, *TM.getTargetData());
-
-    // Save function name for later type emission.
-    if (const Function *F = dyn_cast<Function>(GV))
-      if (F->isDeclaration())
-        COFFMMI.addExternalFunction(Symb->getName());
-
-  }
+  MCSymbol *Symb = Mang->getSymbol(GV);
+  
+  if (!Subtarget->isTargetCygMing() || !isa<Function>(GV))
+    return Symb;
+  
+  X86COFFMachineModuleInfo &COFFMMI =
+    MMI->getObjFileInfo<X86COFFMachineModuleInfo>();
+  COFFMMI.DecorateCygMingName(Symb, OutContext, GV, *TM.getTargetData());
+
+  // Save function name for later type emission.
+  const Function *F = cast<Function>(GV);
+  if (F->isDeclaration())
+    COFFMMI.addExternalFunction(Symb->getName());
 
   return Symb;
 }





More information about the llvm-commits mailing list