[llvm-commits] [llvm] r98116 - in /llvm/trunk/lib/CodeGen/AsmPrinter: DwarfDebug.cpp DwarfException.cpp DwarfPrinter.cpp

Chris Lattner clattner at apple.com
Tue Mar 9 18:30:03 PST 2010


On Mar 9, 2010, at 5:45 PM, Eli Friedman wrote:

> On Tue, Mar 9, 2010 at 5:04 PM, Chris Lattner <sabre at nondot.org> wrote:
>> @@ -2617,12 +2611,10 @@
>>       if (LineInfo.getLine() == 0) continue;
>> 
>>       if (Asm->isVerbose()) {
>> -        std::pair<unsigned, unsigned> SourceID =
>> +        std::pair<unsigned, unsigned> SrcID =
>>           getSourceDirectoryAndFileIds(LineInfo.getSourceID());
>> -        O << '\t' << MAI->getCommentString() << ' '
>> -          << getSourceDirectoryName(SourceID.first) << '/'
>> -          << getSourceFileName(SourceID.second)
>> -          << ':' << utostr_32(LineInfo.getLine()) << '\n';
>> +        Asm->OutStreamer.AddComment(Twine(getSourceDirectoryName(SrcID.first)) +
>> +                                    ":" + Twine(LineInfo.getLine()));
> 
> Did you mean to eliminate the call to getSourceFileName()?

No I didn't, great catch, thanks!

-Chris



More information about the llvm-commits mailing list