[llvm-commits] [PATCH] remove redundant 'static'

Chris Lattner clattner at apple.com
Mon Mar 8 17:17:26 PST 2010


On Mar 8, 2010, at 5:05 PM, Zhongxing Xu wrote:

> 2010/3/9 Chris Lattner <clattner at apple.com>:
>> 
>> On Mar 8, 2010, at 4:45 AM, Zhongxing Xu wrote:
>> 
>>> 'static' is redundant in this context:
>> 
>> Um, no it's not.  It prevents exporting the symbol from the .o file.  What are you trying to fix?
>> 
> 
> 'const' in namespace scope implies internal linkage. Is that
> sufficient to prevent exporting the symbol from the .o file?

It could be, but why do this?  What does it fix?  IMO, static is a lot less subtle.

-Chris



More information about the llvm-commits mailing list