[llvm-commits] [PATCH] Delete the CompileUnits that DwarfDebug allocates

Devang Patel dpatel at apple.com
Mon Mar 8 14:38:08 PST 2010


On Mar 6, 2010, at 3:20 PM, Jeffrey Yasskin wrote:

> On Sat, Mar 6, 2010 at 1:51 AM, Jeffrey Yasskin <jyasskin at google.com> wrote:
>> DwarfDebug new's CompileUnits in beginModule() but never deleted them.
>> This patch deletes them in endModule(), but I don't know enough about
>> how DwarfDebug is used to know for sure that's right. Please
>> double-check it.
> 
> Here's a new patch which also destroys the DbgScopes.

The patch looks good. I removed CompileUnitsMap from mainline sources today, so you'll have to update this patch accordingly.

Thanks for working on this!
-
Devang

> I'm still
> working on testing it against the FrontendC* set. It passes the rest
> of check-lit.
> This should enable my MDNode deletion patch to go in, but I haven't
> tested that again either.
> <delete_cu_and_dbgscopes.patch>





More information about the llvm-commits mailing list