[llvm-commits] [llvm] r96421 - /llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp

[Chris Lattner]

On Feb 16, 2010, at 4:37 PM, Dan Gohman wrote:

> Author: djg
> Date: Tue Feb 16 18:37:20 2010
> New Revision: 96421
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=96421&view=rev
> Log:
> Make the operand and format specifier match, and print all
> 64 bits, fixing a variety of problems.

Nice catch, does a similar bug exist in the X86IntelInstPrinter?

-Chris

> 
> Modified:
>    llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp
> 
> Modified: llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp?rev=96421&r1=96420&r2=96421&view=diff
> 
> ==============================================================================
> --- llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp (original)
> +++ llvm/trunk/lib/Target/X86/AsmPrinter/X86ATTInstPrinter.cpp Tue Feb 16 18:37:20 2010
> @@ -73,7 +73,7 @@
>     O << '$' << Op.getImm();
> 
>     if (CommentStream && (Op.getImm() > 255 || Op.getImm() < -256))
> -      *CommentStream << format("imm = 0x%X\n", Op.getImm());
> +      *CommentStream << format("imm = 0x%llX\n", (long long)Op.getImm());
> 
>   } else {
>     assert(Op.isExpr() && "unknown operand kind in printOperand");
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits