[llvm-commits] [llvm] r95557 - /llvm/trunk/include/llvm/Type.h

[Chris Lattner]

On Feb 8, 2010, at 12:58 PM, Duncan Sands wrote:

> Hi Chris,
>
>> Why not just use isa<PointerType>?
>> This encourages code to diverge in style.
>
> since there already is isFloat, isInteger and variations, it seems  
> odd not
> to have these too.  Of course, I could just delete all the guys with  
> an "isa"
> version.  What do you think?

isInteger is required because we need an argument.  I don't really  
care one way or another though, so long as the code is consistent.   
Are you willing to change all isa<PointerType>(x) to X->isPointer() ?

-Chris