[llvm-commits] [PATCH] Move --march, --mcpu, and --mattr to TargetMachine.cpp (issue199072)

[Jeffrey Yasskin]

On Thu, Feb 4, 2010 at 11:05 PM, Daniel Dunbar <daniel at zuster.org> wrote:
> On Thu, Feb 4, 2010 at 8:29 PM, Jeffrey Yasskin <jyasskin at google.com> wrote:
>> On Thu, Feb 4, 2010 at 7:32 PM, Daniel Dunbar <daniel at zuster.org> wrote:
>>> On Thu, Feb 4, 2010 at 3:31 PM, Jeffrey Yasskin <jyasskin at google.com> wrote:
>>>> Sure. Done at http://codereview.appspot.com/download/issue199072_2002.diff
>>>> or http://codereview.appspot.com/199072.
>>>
>>> Much better, we definitely do not want to increase the visibility of
>>> the backend's command line options.
>>>
>>> Would it make sense to have optional arguments for these -- most
>>> simple clients aren't going to care to pass them, and it keeps source
>>> compatibility.
>>
>> That's what the EngineBuilder is for. Instead of making people
>> remember the order of 10 different parameters, and pass the defaults
>> for earlier ones if they want to set a later one, they create an
>> EngineBuilder, set exactly the parameters they want, and then call
>> create().
>
> Ok.

Thanks! Committed as r95390.