[llvm-commits] [PATCH] Move --march, --mcpu, and --mattr to TargetMachine.cpp (issue199072)

[Jeffrey Yasskin]

On Tue, Feb 2, 2010 at 11:33 PM, Duncan Sands <baldrick at free.fr> wrote:
> Hi,
>
>> Please review this at http://codereview.appspot.com/199072/show
>
> what is the advantage of using this codereview thingy?

You can double-click on a line you want to comment on, and all the
context is already there. And when I update the patchset, everyone can
immediately see that I've changed it and what I've changed, rather
than having to re-scan the diff.

But Rietveld (codereview.appspot.com) puts the "Please review" line
into the email on its own. I don't really care if you want to review
the diff instead (which I linked and is available through the
"Download raw patch set" link on Rietveld).

Jeffrey