[llvm-commits] [PATCH] Move --march, --mcpu, and --mattr to TargetMachine.cpp (issue199072)

jyasskin at gmail.com jyasskin at gmail.com
Tue Feb 2 19:03:28 PST 2010


Reviewers: llvm-commits_cs.uiuc.edu,

Message:
Please take a look. The current patch is at
http://codereview.appspot.com/download/issue199072_1.diff

Description:
Both llc.cpp and JIT/TargetSelect.cpp defined these flags, meaning that
when I link all of LLVM's libraries into a single shared library, llc
crashes on startup with duplicate flag definitions.

This patch moves the flag definitions into TargetMachine (which made
sense in my head, but the exact location doesn't really matter).

Please review this at http://codereview.appspot.com/199072/show

Affected files:
   M     include/llvm/Target/TargetOptions.h
   M     lib/ExecutionEngine/JIT/TargetSelect.cpp
   M     lib/Target/TargetMachine.cpp
   M     tools/llc/llc.cpp





More information about the llvm-commits mailing list