[llvm-commits] [llvm] r94696 - /llvm/trunk/include/llvm-c/EnhancedDisassembly.h

[Chris Lattner]

On Jan 27, 2010, at 3:03 PM, Sean Callanan wrote:
> URL: http://llvm.org/viewvc/llvm-project?rev=94696&view=rev
> Log:
> Added a header file defining the externally-visible C API
> for the LLVM disassemblers.

Hi Sean,

One thing:

> +/*! @constant kEDAssemblySyntaxX86Intel Intel syntax for i386 and x86_64. */
> +const EDAssemblySyntax_t kEDAssemblySyntaxX86Intel  = 0;
> +/*! @constant kEDAssemblySyntaxX86ATT AT&T syntax for i386 and x86_64. */
> +const EDAssemblySyntax_t kEDAssemblySyntaxX86ATT    = 1;  

Please use enums for things like this: in C, these are global variable definitions.

-Chris