[llvm-commits] [llvm] r94567 - /llvm/trunk/lib/Transforms/Utils/PromoteMemoryToRegister.cpp

[Victor Hernandez]

Good catch, Nick.  Looks like Chris already fixed this.

Victor

On Jan 26, 2010, at 6:59 PM, Nick Lewycky wrote:

> Victor Hernandez wrote:
>> Author: hernande
>> Date: Tue Jan 26 12:57:53 2010
>> New Revision: 94567
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=94567&view=rev
>> Log:
>> Switch AllocaDbgDeclares to SmallVector and don't leak DIFactory
>> 
>> Modified:
>>     llvm/trunk/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
>> 
>> Modified: llvm/trunk/lib/Transforms/Utils/PromoteMemoryToRegister.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/PromoteMemoryToRegister.cpp?rev=94567&r1=94566&r2=94567&view=diff
>> 
>> ==============================================================================
>> --- llvm/trunk/lib/Transforms/Utils/PromoteMemoryToRegister.cpp (original)
>> +++ llvm/trunk/lib/Transforms/Utils/PromoteMemoryToRegister.cpp Tue Jan 26 12:57:53 2010
>> @@ -203,7 +203,7 @@
>>      /// AllocaDbgDeclares - For each alloca, we keep track of the dbg.declare
>>      /// intrinsic that describes it, if any, so that we can convert it to a
>>      /// dbg.value intrinsic if the alloca gets promoted.
>> -    std::vector<DbgDeclareInst*>  AllocaDbgDeclares;
>> +    SmallVector<DbgDeclareInst*, 8>  AllocaDbgDeclares;
>> 
>>      /// Visited - The set of basic blocks the renamer has already visited.
>>      ///
>> @@ -219,6 +219,9 @@
>>      PromoteMem2Reg(const std::vector<AllocaInst*>  &A, DominatorTree&dt,
>>                     DominanceFrontier&df, AliasSetTracker *ast)
>>        : Allocas(A), DT(dt), DF(df), DIF(0), AST(ast) {}
>> +    ~PromoteMem2Reg() {
>> +      if (DIF) delete DIF;
> 
> Please drop the if(), it's a no-op to delete a null pointer.
> 
> Nick
> 
>> +    }
>> 
>>      void run();
>> 
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>> 
>