[llvm-commits] [llvm] r94400 - in /llvm/trunk: lib/Target/ARM/ARMMCAsmInfo.cpp test/CodeGen/ARM/align.ll test/CodeGen/ARM/globals.ll

[Chris Lattner]

On Jan 24, 2010, at 7:00 PM, Rafael Espindola wrote:

>> This is almost certainly a bug:
>> 
>> ARMMCAsmInfoDarwin::ARMMCAsmInfoDarwin() {
>> ...
>>  COMMDirectiveTakesAlignment = false;
>> 
>> Jim, can you see if the darwin assembler accepts _bar with this line removed?  If so, please remove it.
> 
> btw, if there is any target that doesn't we are not producing alignment for it:
> 
>  if (ByteAlignment != 0 && MAI.getCOMMDirectiveTakesAlignment()) {
>    if (MAI.getAlignmentIsInBytes())
>      OS << ',' << ByteAlignment;
>    else
>      OS << ',' << Log2_32(ByteAlignment);
>  }
> 
> The else is missing :-)

It looks like the only targets that have COMMDirectiveTakesAlignment=false are x86-COFF targets (mingw/cygwin) and darwin/arm.  I don't know what cygwin GCC compiles it into, it would be very interesting to see.  COMMDirectiveTakesAlignment should probably just be removed if cygwin supports alignment.

-Chris