[llvm-commits] [llvm] r93670 - in /llvm/trunk/lib: CodeGen/MachOWriter.cpp MC/MCMachOStreamer.cpp

Nate Begeman natebegeman at mac.com
Sat Jan 16 19:49:02 PST 2010


Author: sampo
Date: Sat Jan 16 21:49:01 2010
New Revision: 93670

URL: http://llvm.org/viewvc/llvm-project?rev=93670&view=rev
Log:
Add a note for the macho streamer and remove a used of the mangler from the soon to be defunct machowriter pass.

Modified:
    llvm/trunk/lib/CodeGen/MachOWriter.cpp
    llvm/trunk/lib/MC/MCMachOStreamer.cpp

Modified: llvm/trunk/lib/CodeGen/MachOWriter.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachOWriter.cpp?rev=93670&r1=93669&r2=93670&view=diff

==============================================================================
--- llvm/trunk/lib/CodeGen/MachOWriter.cpp (original)
+++ llvm/trunk/lib/CodeGen/MachOWriter.cpp Sat Jan 16 21:49:01 2010
@@ -69,9 +69,6 @@
 }
 
 bool MachOWriter::doInitialization(Module &M) {
-  Mang = new Mangler(M, MAI->getGlobalPrefix(), MAI->getPrivateGlobalPrefix(),
-                     MAI->getLinkerPrivateGlobalPrefix());
-  
   // Initialize TargetLoweringObjectFile.
   TM.getTargetLowering()->getObjFileLowering().Initialize(OutContext, TM);
 
@@ -81,9 +78,6 @@
 /// doFinalization - Now that the module has been completely processed, emit
 /// the Mach-O file to 'O'.
 bool MachOWriter::doFinalization(Module &M) {
-  // Release the name mangler object.
-  delete Mang; Mang = 0;
-
   OutStreamer.Finish();
   return false;
 }

Modified: llvm/trunk/lib/MC/MCMachOStreamer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCMachOStreamer.cpp?rev=93670&r1=93669&r2=93670&view=diff

==============================================================================
--- llvm/trunk/lib/MC/MCMachOStreamer.cpp (original)
+++ llvm/trunk/lib/MC/MCMachOStreamer.cpp Sat Jan 16 21:49:01 2010
@@ -353,6 +353,8 @@
   if (!Emitter)
     llvm_unreachable("no code emitter available!");
 
+  // FIXME: Emitting an instruction should cause S_ATTR_SOME_INSTRUCTIONS to
+  //        be set for the current section.
   // FIXME: Relocations!
   SmallString<256> Code;
   raw_svector_ostream VecOS(Code);





More information about the llvm-commits mailing list