[llvm-commits] [llvm-gcc-4.2] r93409 - /llvm-gcc-4.2/trunk/gcc/llvm-convert.cpp

[Evan Cheng]

On Jan 14, 2010, at 2:03 AM, Duncan Sands wrote:

> Hi Evan,
> 
>> Add missing memory barrier after binary atomic builtin. r74403 apparently left this out by mistake. x86 target will optimize it away but it's looking for the barrier after the operation.
> 
> what do you mean by "it's looking for the barrier after the operation"?

DAG combine is looking for the ISD::MemBarrier node that's the successor of the atomic op.

> 
>> +#if defined(TARGET_ARM) && defined(CONFIG_DARWIN_H)
> 
> Should this really be conditioned on the OS (darwin)?  After all, how
> barriers work should be a processor issue, not an OS one...

I have no idea. That's how it was written.

Evan

> 
> Ciao,
> 
> Duncan.