[llvm-commits] [patch] Add support for emulators in RunSafely.sh

[Nick Lewycky]

On 13 January 2010 16:20, Rafael Espindola <espindola at google.com> wrote:

> > Looks good to me. Thanks Rafael!
>
> OK, it was not so simple because of the strict argument order. Fixed.
> I also fixed the very long lines is Makefile.programs.
>

Yuck. Without proper flags processing, this whole script should probably
just use environment variables instead. Anyways, thanks for the refactoring,
this looks much better.

Note that RunSafelyAndStable.sh cannot take options.
>

No, but I'm not sure it needs to. It takes <program> <args...> which means
that "prog foo" could become "wrapper prog foo" with no difference in
behaviour. But after taking another look, I don't see any of the makefiles
in llvm-test actually using GET_STABLE_NUMBERS. I guess you don't really
need to support that. :)

So with that said, this patch *once again* looks fine, but then, so did all
the others ;)

Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100113/dd081646/attachment.html>