[llvm-commits] [llvm-gcc-4.2] r93388 - in /llvm-gcc-4.2/trunk/gcc/testsuite/gcc.dg: ssp-1.c ssp-2.c

[Stuart Hastings]

On Jan 13, 2010, at 4:47 PM, Bill Wendling wrote:

> Would using "memset" be good here instead of the iterator?

Hm.  memset() couldn't be any worse.

Can you think of a target or situation where memset() would be better?

stuart

> -bw
>
> On Jan 13, 2010, at 4:46 PM, Stuart Hastings wrote:
>
>> Author: stuart
>> Date: Wed Jan 13 18:46:15 2010
>> New Revision: 93388
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=93388&view=rev
>> Log:
>> Move loop index out of stack in stack-clobbering testcases.
>>
>> Modified:
>>   llvm-gcc-4.2/trunk/gcc/testsuite/gcc.dg/ssp-1.c
>>   llvm-gcc-4.2/trunk/gcc/testsuite/gcc.dg/ssp-2.c
>>
>> Modified: llvm-gcc-4.2/trunk/gcc/testsuite/gcc.dg/ssp-1.c
>> URL: http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/testsuite/gcc.dg/ssp-1.c?rev=93388&r1=93387&r2=93388&view=diff
>>
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =
>> =====================================================================
>> --- llvm-gcc-4.2/trunk/gcc/testsuite/gcc.dg/ssp-1.c (original)
>> +++ llvm-gcc-4.2/trunk/gcc/testsuite/gcc.dg/ssp-1.c Wed Jan 13  
>> 18:46:15 2010
>> @@ -11,7 +11,7 @@
>>
>> int main ()
>> {
>> -  int i;
>> +  static int i;		/* Can't allocate this on the stack.  */
>>  char foo[255];
>>
>>  // smash stack
>>
>> Modified: llvm-gcc-4.2/trunk/gcc/testsuite/gcc.dg/ssp-2.c
>> URL: http://llvm.org/viewvc/llvm-project/llvm-gcc-4.2/trunk/gcc/testsuite/gcc.dg/ssp-2.c?rev=93388&r1=93387&r2=93388&view=diff
>>
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> = 
>> =====================================================================
>> --- llvm-gcc-4.2/trunk/gcc/testsuite/gcc.dg/ssp-2.c (original)
>> +++ llvm-gcc-4.2/trunk/gcc/testsuite/gcc.dg/ssp-2.c Wed Jan 13  
>> 18:46:15 2010
>> @@ -12,7 +12,7 @@
>> void
>> overflow()
>> {
>> -  int i = 0;
>> +  static int i = 0;	/* Can't allocate this on the stack.  */
>>  char foo[30];
>>
>>  /* Overflow buffer.  */
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>