[llvm-commits] [patch] Add support for emulators in RunSafely.sh

Rafael Espindola espindola at google.com
Wed Jan 13 15:18:00 PST 2010


2010/1/13 Nick Lewycky <nlewycky at google.com>:
> This could be used for a valgrind as well, for example. Maybe the flag
> should be named "run_under" instead of emulator? I'm on the fence on that
> because valgrind really is an emulator under the hood.

It could be something else, so it is a good point.

> This isn't compatible GET_STABLE_NUMBERS, nor remote execution. Instead of
> modifying just one RUNSAFELY line to add $(EMULATOR_OPT), you should put:
>
>   ifdef EMULATOR
>     RUNSAFELY := $(RUNSAFELY) $(EMULATOR_OPT)
>   endif
>
> at line 109.

Updated patch attached. I am testing it.

> Nick

Cheers,
-- 
Rafael Ávila de Espíndola
-------------- next part --------------
A non-text attachment was scrubbed...
Name: run-under.patch
Type: text/x-diff
Size: 1478 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20100113/9c49b542/attachment.patch>


More information about the llvm-commits mailing list