[llvm-commits] [llvm] r93308 - /llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp

[Chris Lattner]

Author: lattner
Date: Wed Jan 13 02:02:14 2010
New Revision: 93308

URL: http://llvm.org/viewvc/llvm-project?rev=93308&view=rev
Log:
add a fixme, ELF MCSection isn't quite right and weak unnamed globals are broken
on linux (even though they are pointless, they shouldn't ICE).

Modified:
    llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp

Modified: llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp?rev=93308&r1=93307&r2=93308&view=diff

==============================================================================
--- llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp (original)
+++ llvm/trunk/lib/Target/TargetLoweringObjectFile.cpp Wed Jan 13 02:02:14 2010
@@ -578,6 +578,10 @@
     const char *Prefix = getSectionPrefixForUniqueGlobal(Kind);
     SmallString<128> Name;
     Name.append(Prefix, Prefix+strlen(Prefix));
+    // FIXME: This will fail for weak globals with no names, this also depends
+    // on the mangling behavior of makeNameProper to mangle the section name
+    // before construction.  Instead, this should use getNameWithPrefix on the
+    // global variable and the MCSection printing code should do the mangling.
     Mang->makeNameProper(Name, GV->getName());
 
     return getELFSection(Name.str(),