[llvm-commits] [llvm] r92761 - in /llvm/trunk: docs/LangRef.html include/llvm/Metadata.h lib/AsmParser/LLParser.cpp lib/Bitcode/Reader/BitcodeReader.cpp lib/VMCore/Metadata.cpp unittests/VMCore/MetadataTest.cpp

[Devang Patel]

On Jan 8, 2010, at 11:45 AM, Chris Lattner wrote:

>> +++ llvm/trunk/docs/LangRef.html Tue Jan  5 14:41:31 2010
>
> You should also mention these in #modulestructure and add a top  
> level section to "High Level Structure" after #aliasstructure  
> describing these.  Please describe what the constraints are on  
> these: the operand has to be an MDNode or null.
>
> @@ -2329,6 +2329,9 @@
>>   event that a value is deleted, it will be replaced with a typeless
>>   "<tt>null</tt>", such as "<tt>metadata !{null, i32 10}</tt>".</p>
>>
>> +<p>A named metadata is a collection of metadata nodes. For  
>> example: "<tt>!foo =
>> +   metadata !{!4, !3}</tt>".
>
> Please link to the section you add above.
>
> In the TOC and in the document, Embedded Metadata should not be  
> listed under Constants anymore, it should move to Other Values.  The  
> Embedded Metadata section should be renamed "Metadata Nodes and  
> Metadata Strings".

Done.
-
Devang
>