[llvm-commits] [llvm] r83190 - in /llvm/trunk: include/llvm/Support/DebugLoc.h lib/Analysis/DebugInfo.cpp lib/CodeGen/AsmPrinter/AsmPrinter.cpp

[Chris Lattner]

On Jan 4, 2010, at 8:59 AM, Devang Patel wrote:

> 
> On Jan 3, 2010, at 9:23 PM, Chris Lattner wrote:
> 
>> 
>> On Sep 30, 2009, at 6:15 PM, Devang Patel wrote:
>> 
>>> Author: dpatel
>>> Date: Wed Sep 30 20:15:28 2009
>>> New Revision: 83190
>>> 
>>> URL: http://llvm.org/viewvc/llvm-project?rev=83190&view=rev
>>> Log:
>>> Add another MDNode into DebugLocTuple. This will be used to keep track of inlined functions.
>> 
>> Do you need both InlinedLoc and CompileUnit?  Can't one be obtained from the other?
> 
> I later renamed CompileUnit to Scope to avoid this confusion :)
> 
> Scope describes instruction's scope, which can be file scope or compile unit or function scope or lexical scope.
> InlinedLoc points to another DebugLocTuple.
> 
> In fact, "struct DbugLocTuple" can be directly replaced by DILocation. That's what llvm::Instruction uses.

Ok, please replace DbugLocTuple with DILocation so we only have one concept here.  Thanks!

-Chris